Issues
Contents
One of the easiest ways to contribute to the website & wiki is through Github’s “Issues” feature. Here, you can report bugs, flag articles that need updating, or suggest new wiki pages – basically, it helps us create and maintain a to-do list for the site!
If you’re new to editing the wiki, this can be a great place to start contributing requested content. Just filter the issues by the “good first issue” label, or click here.
What’s an issue?
Generally, the Issues feature should be used for medium-sized content tasks, and for reporting any usability problems with the site. Issues should also be well-scoped and have very clear “done” condition.
Some examples of good issues are:
- Site bugs
- A broken page
- A page with lots of broken links
- A broken link you don’t know how to fix
- Visual or layout bugs
- Content
- A missing character page
- A missing NPC, faction, or location
- A stub that should be expanded to a wiki page
- Content addition to an existing wiki page
What’s not an issue?
Avoid reporting issues that would take you a very short time to fix personally (e.g., 1-2 minutes); instead, just make the changes directly to the content
branch. Additionally, do not open issues that have vague end conditions, or have a very large scope of work.
Some examples of bad issues are:
- Easily fixable broken links
- Spelling or grammar errors
- Suggestions for website layout or organization
- Addition of a new section to the website
How-To
Create an Issue
- Visit the Issues home page.
- Click “New Issue”. You should see the following screen.
- Add a title (1) and description (2).
Note: Use templates when possible. When an appropriate template is not available, include as much context as possible in the title and description, and take advantage of Markdown formatting to make the request easy to read & understand. - Assign labels using the right-side panel (3).
- Click “Submit New Issue” (4).
Start Work on an Issue
The best practice when resolving issues is to create a new branch linked to the issue, make changes to that branch, and then create a pull request to merge the changes into the content
branch.
- Select an issue from the Issues home page.
- Click create a branch under the Development tab on the issue’s page.
- Make sure checkout locally is checked, then click create branch.
- Close the pop-up.
- There should now be a link to the new branch under the Development tab.
Click on that link. It will take you to the new branch, which is basically a copy of the site you can edit freely without messing up the current site. - Find and edit the files you need to change. The exact process and files depend on which issue you are resolving; for more details on how to find and change files, refer to the relevant documentation. Some common ones are:
- Editing Existing Wiki Pages (Beginner)
- Adding Wiki Pages (Intermediate) — coming soon!
- Adding Page Stubs and Site Data (Intermediate) – coming soon!
- Layout changes and site generation (Advanced) – coming soon!
- Commit your changes to the issue branch as you edit the files. You (and other contributors!) can also add comments to the issue page to ask questions, provide clarification, or debate the merits of certain edits.
Close an Issue
After all changes needed to resolve the issue are commited, the next step is to update the site content with the new changes. Here’s how that works.
- Create a pull request to merge your issue branch into the
content
branch. On the pull request page, make sure thecontent
branch is on the left, and the issue branch is on the right! - Click Create pull request.
- Click Merge pull request on the next page, then Confirm merge. This will update the
content
branch with the new changes. - Click Delete branch to delete the issue branch. We no longer need the issue branch now that the changes have been merged into the
content
branch. - Go back to the issue’s page and scroll to the bottom.
- Select Close Issue.
Congratulations! Your update will be included the next time the content
branch is merged to the gh-pages
branch. (If you’re feeling ambitious, go ahead and create that pull request yourself.)
Resources
Issue Templates
Here are some templates you can use to create issues for common occurrences, such as missing content and/or data, along with links to examples of each.
Add Player Character page
Title: Add [character name] to player characters
Labels: add wiki page
Description:
Examples: here
Add content to existing page
Title: Add Short Description of [item] to [wiki page]
Labels: good first issue, additional page content
Description:
Examples: here
Request a new stub
Title: Add [category] stub for [item]
Labels: add data
Description:
Examples: here
Expand stub to wiki page
Title: Expand [item] stub to wiki page
Labels: add wiki page
Description:
Examples: here